Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8591] Preliminary support for key commands of LMQ #8590

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Aug 28, 2024

Which Issue(s) This PR Fixes

Fixes #8591

Brief Description

Preliminary support for key commands of LMQ

  • topicStatus
  • consumerProgress
  • resetOffsetByTime
  • queryMsgByUniqueKey
  • queryMsgByKey
  • queryMsgById

How Did You Test This Change?

Test the relevant commands
image
image
image

@RongtongJin RongtongJin changed the title Preliminary support for key commands of LMQ [ISSUE #8591] Preliminary support for key commands of LMQ Aug 28, 2024
@RongtongJin RongtongJin marked this pull request as draft August 28, 2024 03:16
@RongtongJin RongtongJin marked this pull request as draft August 28, 2024 03:16
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 108 lines in your changes missing coverage. Please review.

Project coverage is 47.20%. Comparing base (9e6bbf7) to head (4d5b294).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 34.61% 30 Missing and 4 partials ⚠️
...tmq/tools/command/topic/TopicStatusSubCommand.java 20.00% 12 Missing ⚠️
...apache/rocketmq/tools/admin/DefaultMQAdminExt.java 8.33% 11 Missing ⚠️
...tools/command/message/QueryMsgByKeySubCommand.java 0.00% 11 Missing ⚠️
...a/org/apache/rocketmq/client/impl/MQAdminImpl.java 37.50% 6 Missing and 4 partials ⚠️
.../tools/command/message/QueryMsgByIdSubCommand.java 0.00% 10 Missing ⚠️
...s/command/consumer/ConsumerProgressSubCommand.java 0.00% 5 Missing ⚠️
...ols/command/offset/SkipAccumulationSubCommand.java 0.00% 5 Missing ⚠️
...command/message/QueryMsgByUniqueKeySubCommand.java 63.63% 2 Missing and 2 partials ⚠️
...tools/command/offset/ResetOffsetByTimeCommand.java 57.14% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8590      +/-   ##
=============================================
- Coverage      47.23%   47.20%   -0.04%     
- Complexity     11445    11459      +14     
=============================================
  Files           1275     1277       +2     
  Lines          89246    89421     +175     
  Branches       11471    11500      +29     
=============================================
+ Hits           42159    42208      +49     
- Misses         41886    42002     +116     
- Partials        5201     5211      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin marked this pull request as ready for review August 28, 2024 10:37
@lizhanhui lizhanhui merged commit e5e3839 into apache:develop Aug 30, 2024
10 checks passed
lizhanhui pushed a commit to qianye1001/rocketmq that referenced this pull request Aug 30, 2024
…he#8590)

* Preliminary support for key commands of LMQ

* Preliminary support for key commands of LMQ

* Optimize some code

* Fix some bugs and UTs for lmq support

* Fix UTs can not pass

* Fix UTs can not pass

* Add some check to prevent NPE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Preliminary support for key commands of LMQ
3 participants