[ISSUE #8601]When isPopShouldStop hit,unlock queueLockManager #8602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizhiyuan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8602 +/- ##
===========================================
Coverage 47.20% 47.20%
- Complexity 11412 11456 +44
===========================================
Files 1275 1277 +2
Lines 89110 89344 +234
Branches 11468 11481 +13
===========================================
+ Hits 42061 42177 +116
- Misses 41873 41965 +92
- Partials 5176 5202 +26 ☔ View full report in Codecov by Sentry. |
lizhanhui
reviewed
Aug 29, 2024
broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
Outdated
Show resolved
Hide resolved
cserwen
previously approved these changes
Aug 29, 2024
Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8601
Brief Description
When isPopShouldStop hit，unlock queueLockManager
How Did You Test This Change?
review the code