[ISSUE #8607] Exclude loopback addresses when iterating over local network interfaces #8608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8608 +/- ##
=============================================
- Coverage 47.23% 47.19% -0.04%
+ Complexity 11462 11452 -10
=============================================
Files 1277 1277
Lines 89342 89344 +2
Branches 11480 11481 +1
=============================================
- Hits 42202 42169 -33
- Misses 41942 41972 +30
- Partials 5198 5203 +5 ☔ View full report in Codecov by Sentry. |
RongtongJin
approved these changes
Aug 30, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8607
Brief Description
This PR addresses an issue in the
NetworkUtilclass where the loopback address (127.0.0.1) might be mistakenly selected when all available IP addresses are internal. The fix involves ensuring that loopback addresses are excluded when traversinglocalInetAddressList.How Did You Test This Change?
The test workflow