-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8618] Supports getting consumer group information for all pop patterns on the broker #8619
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8619 +/- ##
=============================================
- Coverage 47.45% 47.38% -0.08%
+ Complexity 11617 11603 -14
=============================================
Files 1284 1284
Lines 90025 90033 +8
Branches 11585 11587 +2
=============================================
- Hits 42724 42664 -60
- Misses 42065 42120 +55
- Partials 5236 5249 +13 ☔ View full report in Codecov by Sentry. |
public MessageRequestModeSerializeWrapper getAllMessageRequestMode(final String brokerAddr) throws MQBrokerException, | ||
RemotingConnectException, RemotingSendRequestException, RemotingTimeoutException, InterruptedException { | ||
RemotingCommand request = RemotingCommand.createRequestCommand(RequestCode.GET_ALL_MESSAGE_REQUEST_MODE, null); | ||
RemotingCommand response = this.remotingClient.invokeSync(brokerAddr, request, 3000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may timeout when execute get all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The local test does not time out, I can increase the timeout parameter if necessary
Which Issue(s) This PR Fixes
Fixes #8618
Brief Description
How Did You Test This Change?