[ISSUE #8609] Add the BrokerConfig updateNameServerAddrPeriod #8626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esrv address can be configured.
lizhimins
previously approved these changes
Sep 3, 2024
RongtongJin
reviewed
Sep 3, 2024
| /** | ||
| * This configurable item defines interval of update name server address. Default: 120 * 1000 milliseconds | ||
| */ | ||
| private int updateNameServerAddrPeriod = 1000 * 120; |
There was a problem hiding this comment.
Naming updateNameServerAddrInterval would be better
RongtongJin
previously approved these changes
Sep 3, 2024
…e#8633) * Skip flaky tests on macOS * Trigger ci * Remove branch trigger
qianye1001
dismissed stale reviews from RongtongJin, lollipopjin, and lizhimins
via
d0c8129
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8626 +/- ##
=============================================
- Coverage 47.28% 47.19% -0.10%
+ Complexity 11485 11460 -25
=============================================
Files 1277 1277
Lines 89425 89430 +5
Branches 11502 11502
=============================================
- Hits 42289 42207 -82
- Misses 41946 42015 +69
- Partials 5190 5208 +18 ☔ View full report in Codecov by Sentry. |
lizhimins
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ddress can be configured.
Which Issue(s) This PR Fixes
Fixes #8609
Brief Description
How Did You Test This Change?