Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8647] Fix the issue where lmq cannot update consumer offset #8648

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8647

Brief Description

If it is a group of lmq, return true directly during the check.

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.17%. Comparing base (632943e) to head (38b7351).
Report is 51 commits behind head on develop.

Files with missing lines Patch % Lines
...oker/subscription/LmqSubscriptionGroupManager.java 0.00% 3 Missing ⚠️
...bscription/RocksDBLmqSubscriptionGroupManager.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8648      +/-   ##
=============================================
- Coverage      47.19%   47.17%   -0.02%     
- Complexity     11458    11469      +11     
=============================================
  Files           1277     1277              
  Lines          89425    89436      +11     
  Branches       11502    11502              
=============================================
- Hits           42201    42191      -10     
- Misses         42014    42032      +18     
- Partials        5210     5213       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caigy caigy merged commit 5496807 into apache:develop Sep 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] LMQ cannot update consumer offset because it needs to check if the subscriptionGroup exists
6 participants