Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8653] Fix index service upload last file when broker shutdown and fetcher check in tiered storage #8654

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #8653

Brief Description

How Did You Test This Change?

…utdown and fetcher check in tiered storage
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.40%. Comparing base (97b318f) to head (4b97c31).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../rocketmq/tieredstore/index/IndexStoreService.java 60.00% 5 Missing and 3 partials ⚠️
...pache/rocketmq/tieredstore/TieredMessageStore.java 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8654      +/-   ##
=============================================
- Coverage      47.43%   47.40%   -0.03%     
+ Complexity     11513    11511       -2     
=============================================
  Files           1277     1277              
  Lines          89432    89445      +13     
  Branches       11502    11504       +2     
=============================================
- Hits           42418    42404      -14     
- Misses         41804    41826      +22     
- Partials        5210     5215       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qianye1001
Copy link
Contributor

LGTM

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lollipopjin
lollipopjin previously approved these changes Sep 6, 2024
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins marked this pull request as draft September 6, 2024 13:58
…utdown and fetcher check in tiered storage
@lizhimins lizhimins marked this pull request as ready for review September 7, 2024 07:07
Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 587e976 into apache:develop Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix index service upload last file when broker shutdown and fetcher check in tiered storage
4 participants