Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8691] Fix PR-CI errors #8692

Merged
merged 2 commits into from
Sep 14, 2024
Merged

[ISSUE #8691] Fix PR-CI errors #8692

merged 2 commits into from
Sep 14, 2024

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Sep 12, 2024

Fixes #8691 .

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.47%. Comparing base (00d5047) to head (251e10b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8692      +/-   ##
=============================================
- Coverage      47.54%   47.47%   -0.08%     
+ Complexity     11547    11523      -24     
=============================================
  Files           1277     1277              
  Lines          89449    89455       +6     
  Branches       11504    11505       +1     
=============================================
- Hits           42532    42470      -62     
- Misses         41711    41763      +52     
- Partials        5206     5222      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francisoliverlee
Copy link
Member

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024, it suggests to use v4 on https://github.com/actions/upload-artifact
image

@yx9o
Copy link
Contributor Author

yx9o commented Sep 13, 2024

Thanks for your review, can I upgrade all actions/upload-artifact@v3 to actions/upload-artifact@v4?

@lizhimins
Copy link
Member

Suggest use v4

@yx9o
Copy link
Contributor Author

yx9o commented Sep 13, 2024

All have been upgraded to actions/upload-artifact@v4, please review, thank you.

@RongtongJin RongtongJin merged commit 57d9f8d into apache:develop Sep 14, 2024
11 checks passed
@yx9o yx9o deleted the dev-8691 branch September 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix PR-CI errors
5 participants