Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8712] Set namesrvAddrChoosed to null if choosed addr is not exist. #8713

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

qianye1001
Copy link
Contributor

…ient is no longer in use, a new channel connection will be created.

Which Issue(s) This PR Fixes

Fixes #8712

Brief Description

How Did You Test This Change?

…ient is no longer in use, a new channel connection will be created.
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.41%. Comparing base (280804c) to head (71eb691).
Report is 31 commits behind head on develop.

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8713      +/-   ##
=============================================
- Coverage      47.46%   47.41%   -0.06%     
+ Complexity     11543    11528      -15     
=============================================
  Files           1278     1279       +1     
  Lines          89524    89563      +39     
  Branches       11509    11516       +7     
=============================================
- Hits           42496    42464      -32     
- Misses         41805    41868      +63     
- Partials        5223     5231       +8     
Flag Coverage Δ
47.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fuyou001

This comment was marked as outdated.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR need

…ient is no longer in use, a new channel connection will be created.
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit e8d1472 into apache:develop Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Ensure that when selected Namesrv addr is no longer in use, a new channel will be created.
4 participants