Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8740] fix rocksDBConfigToJson command #8738

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Sep 24, 2024

Which Issue(s) This PR Fixes

Fixes #8740

Brief Description

How Did You Test This Change?

@yuz10 yuz10 changed the title fix rocksDBConfigToJson command [ISSUE #8740] fix rocksDBConfigToJson command Sep 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 47.34%. Comparing base (525f877) to head (49508ba).

Files with missing lines Patch % Lines
...s/command/metadata/RocksDBConfigToJsonCommand.java 0.00% 39 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8738      +/-   ##
=============================================
- Coverage      47.46%   47.34%   -0.12%     
+ Complexity     11566    11546      -20     
=============================================
  Files           1282     1282              
  Lines          89813    89843      +30     
  Branches       11553    11556       +3     
=============================================
- Hits           42626    42538      -88     
- Misses         41956    42056     +100     
- Partials        5231     5249      +18     
Flag Coverage Δ
47.34% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit e2abbc3 into apache:develop Sep 25, 2024
11 checks passed
@yuz10 yuz10 deleted the develop4 branch September 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] rocksDBConfigToJson fail to print subscriptionGroups
3 participants