Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LMQ dispatch in case if Consume Queue Store is RocksDB-based #8842

Merged
merged 12 commits into from
Oct 23, 2024

Conversation

lizhanhui
Copy link
Contributor

Which Issue(s) This PR Fixes

to #8829

Brief Description

How Did You Test This Change?

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
…lush

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 42.55639% with 382 lines in your changes missing coverage. Please review.

Project coverage is 47.29%. Comparing base (1e0b08f) to head (b518616).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 37.90% 70 Missing and 7 partials ⚠️
...rocketmq/broker/metrics/ConsumerLagCalculator.java 0.00% 43 Missing ⚠️
...rocketmq/store/queue/RocksDBConsumeQueueStore.java 48.14% 34 Missing and 8 partials ⚠️
...tieredstore/metrics/TieredStoreMetricsManager.java 0.00% 39 Missing ⚠️
...mq/store/queue/RocksDBConsumeQueueOffsetTable.java 70.17% 21 Missing and 13 partials ⚠️
...rocketmq/broker/processor/PopMessageProcessor.java 16.66% 20 Missing ⚠️
...che/rocketmq/broker/metrics/PopMetricsManager.java 7.69% 12 Missing ⚠️
...main/java/org/apache/rocketmq/store/CommitLog.java 45.00% 10 Missing and 1 partial ⚠️
...ocketmq/store/exception/ConsumeQueueException.java 0.00% 10 Missing ⚠️
...pache/rocketmq/store/exception/StoreException.java 0.00% 10 Missing ⚠️
... and 21 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8842      +/-   ##
=============================================
- Coverage      47.46%   47.29%   -0.17%     
+ Complexity     11617    11610       -7     
=============================================
  Files           1284     1290       +6     
  Lines          90025    90293     +268     
  Branches       11585    11609      +24     
=============================================
- Hits           42728    42706      -22     
- Misses         42061    42314     +253     
- Partials        5236     5273      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@RongtongJin
Copy link
Contributor

@LetLetMe PTAL~

@lizhanhui
Copy link
Contributor Author

@redlsz @leizhiyuan Please also take a look

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhanhui lizhanhui merged commit b86059c into apache:develop Oct 23, 2024
11 checks passed
@lizhanhui lizhanhui deleted the lmq-dispatch branch October 23, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants