Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][FileConnector] Unify some option in file source/sink connector #5461

Closed
2 of 3 tasks
ruanwenjun opened this issue Sep 11, 2023 · 5 comments · Fixed by #5680
Closed
2 of 3 tasks

[Feature][FileConnector] Unify some option in file source/sink connector #5461

ruanwenjun opened this issue Sep 11, 2023 · 5 comments · Fixed by #5680

Comments

@ruanwenjun
Copy link
Member

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Description

We have some option that is different in the file family connector.

For example, in the FtpFile connector sink, we support compress_codec, but we don't set compress_codec in the source, this might be strange.

And further more, in localfile/ftpfile/hdfsfile, there also exist some option that is different, e.g. some support row_delimiter, some don't support.

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@liunaijie
Copy link
Member

#5083 this pr will support compress_codec in the FileReader

@EricJoy2048
Copy link
Member

Thanks for your contribution.
Can you fix And further more, in localfile/ftpfile/hdfsfile, there also exist some option that is different, e.g. some support row_delimiter, some don't support. ?

@liunaijie
Copy link
Member

Thanks for your contribution. Can you fix And further more, in localfile/ftpfile/hdfsfile, there also exist some option that is different, e.g. some support row_delimiter, some don't support. ?

ok, i will do this.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Oct 29, 2023
@liunaijie
Copy link
Member

make it active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants