-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][connector-file] unifiy option between file source/sink and update document #5680
Conversation
- unified field_delimiter parameter - document update
So after this PR, seem like |
...se/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSourceConfig.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test case for old config key delimiter
? We should make sure the delimiter
work fine too after this change.
sink { | ||
Assert { | ||
rules { | ||
row_rules = [ | ||
{ | ||
rule_type = MAX_ROW | ||
rule_value = 5 | ||
} | ||
], | ||
field_rules = [ | ||
{ | ||
field_name = c_string | ||
field_type = string | ||
field_value = [ | ||
{ | ||
rule_type = NOT_NULL | ||
} | ||
] | ||
}, | ||
{ | ||
field_name = c_boolean | ||
field_type = boolean | ||
field_value = [ | ||
{ | ||
rule_type = NOT_NULL | ||
} | ||
] | ||
} | ||
] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case seem like can not prove the delimiter is ":". Could you add a rule to check row value? You can refer https://github.com/apache/seatunnel/pull/5083/files#diff-a68b2797462655fd5ee139c5c129df223f4de9c25e72e41a6432012d00ede0a8
235259a
to
45e156e
Compare
45e156e
to
bc63282
Compare
Thanks @liunaijie .Waiting CI pass. |
Purpose of this pull request
close #5461 and #4572
a) update parameter name
b) refactor docs using unified format
Does this PR introduce any user-facing change?
yes, the file source paramter delimiter updated to field_delimiter to keep same with sink paramter
How was this patch tested?
use e2e
Check list
New License Guide
release-note
.