Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Doc] Add Config file introduce. #1740

Merged
merged 6 commits into from
Apr 29, 2022
Merged

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Add Config file introduce.

Check list

@Hisoka-X
Copy link
Member Author

@zhongjiajie Hi, PTAL

@zhongjiajie
Copy link
Member

take a look now

docs/en/faq.md Outdated Show resolved Hide resolved
docs/en/start/config.md Outdated Show resolved Hide resolved
docs/sidebars.js Show resolved Hide resolved
docs/sidebars.js Outdated Show resolved Hide resolved
docs/sidebars.js Outdated Show resolved Hide resolved
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @benjfan . BTW, I change the sidebar position between Quick Start and Concept. Because I think the concept is based on users could start and run our first job, it is an advanced topic for users. So it should after quick start

@zhongjiajie zhongjiajie merged commit 7d92e8c into apache:dev Apr 29, 2022
@Hisoka-X
Copy link
Member Author

LGTM, thanks @benjfan . BTW, I change the sidebar position between Quick Start and Concept. Because I think the concept is based on users could start and run our first job, it is an advanced topic for users. So it should after quick start

Thanks for help.

@Hisoka-X Hisoka-X deleted the doc_improve branch April 29, 2022 03:31
ruanwenjun pushed a commit to ruanwenjun/incubator-seatunnel that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants