-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Seatunnel-core-flink/spark] format usage help message #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendtkl
changed the title
[Feature][Seatunnel-core] format usage help output
[Feature][Seatunnel-core-flink/spark] format usage help output
May 4, 2022
legendtkl
changed the title
[Feature][Seatunnel-core-flink/spark] format usage help output
[Feature][Seatunnel-core-flink/spark] format usage help message
May 4, 2022
Hi, @ruanwenjun , would you help review this tiny PR when you're available? Thanks, |
@legendtkl Which system are you using, Windows? |
macOS Monterey @ruanwenjun |
|
@legendtkl Sorry, you are right, I didn't update my code. |
ruanwenjun
requested changes
May 5, 2022
...nel-core-flink/src/test/java/org/apache/seatunnel/core/flink/utils/CommandLineUtilsTest.java
Outdated
Show resolved
Hide resolved
ruanwenjun
approved these changes
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ruanwenjun
pushed a commit
to ruanwenjun/incubator-seatunnel
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
related issue: #1787
With this PR, we can get a better output of usage help message
Before
./start-seatunnel-flink.sh -h Usage: start-seatunnel-flink.sh [options] Options: -t, --check check config Default: false start-seatunnel-flink.sh start-seatunnel-spark.sh start-seatunnel-sql.sh -c, --config Config file -h, --help Show the usage message -r, --run-mode job run mode, run or run-application Default: RUN Possible Values: [RUN, APPLICATION_RUN] -i, --variable variable substitution, such as -i city=beijing, or -i date=20190318 Default: []
After
Usage: start-seatunnel-sql.sh [options] Options: -t, --check check config (default: false) * -c, --config Config file -h, --help Show the usage message -r, --run-mode job run mode, run or run-application (default: RUN) (values: [RUN, APPLICATION_RUN]) -i, --variable variable substitution, such as -i city=beijing, or -i date=20190318 (default: [])
Check list
New License Guide