Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Seatunnel-core-flink/spark] format usage help message #1788

Merged
merged 1 commit into from
May 5, 2022

Conversation

legendtkl
Copy link
Contributor

@legendtkl legendtkl commented May 4, 2022

Purpose of this pull request

related issue: #1787

With this PR, we can get a better output of usage help message

Before

./start-seatunnel-flink.sh -h
Usage: start-seatunnel-flink.sh [options] Options: -t, --check check config Default: false start-seatunnel-flink.sh start-seatunnel-spark.sh start-seatunnel-sql.sh -c, --config Config file -h, --help Show the usage message -r, --run-mode job run mode, run or run-application Default: RUN Possible Values: [RUN, APPLICATION_RUN] -i, --variable variable substitution, such as -i city=beijing, or -i date=20190318 Default: []

After

Usage: start-seatunnel-sql.sh [options]
  Options:
    -t, --check    check config (default: false)
  * -c, --config   Config file
    -h, --help     Show the usage message
    -r, --run-mode job run mode, run or run-application (default: RUN) 
                   (values: [RUN, APPLICATION_RUN])
    -i, --variable variable substitution, such as -i city=beijing, or -i 
                   date=20190318 (default: [])

Check list

@legendtkl legendtkl changed the title [Feature][Seatunnel-core] format usage help output [Feature][Seatunnel-core-flink/spark] format usage help output May 4, 2022
@legendtkl legendtkl changed the title [Feature][Seatunnel-core-flink/spark] format usage help output [Feature][Seatunnel-core-flink/spark] format usage help message May 4, 2022
@legendtkl
Copy link
Contributor Author

Hi, @ruanwenjun , would you help review this tiny PR when you're available?

Thanks,
Kelu.

@ruanwenjun
Copy link
Member

@legendtkl Which system are you using, Windows?

@legendtkl
Copy link
Contributor Author

macOS Monterey @ruanwenjun

@ruanwenjun
Copy link
Member

macOS Monterey @ruanwenjun

It looks well on my laptop(macOS x86).
image

@legendtkl
Copy link
Contributor Author

it's wired... This is my case.

image

image

@ruanwenjun
Copy link
Member

ruanwenjun commented May 5, 2022

@legendtkl Sorry, you are right, I didn't update my code.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit bb067b4 into apache:dev May 5, 2022
ruanwenjun pushed a commit to ruanwenjun/incubator-seatunnel that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants