Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-draft][Optimize] Optimize module name #2062

Merged
merged 5 commits into from
Jun 28, 2022
Merged

[api-draft][Optimize] Optimize module name #2062

merged 5 commits into from
Jun 28, 2022

Conversation

EricJoy2048
Copy link
Member

image

Module name is too long.

@Hisoka-X
Copy link
Member

How about change seatunnel-connectors-flink,seatunnel-connectors-spark,seatunnel-connectors-seatunnel to flink,spark,seatunnel? Because they are seatunnel-connectors's sub module. @ruanwenjun @CalvinKirs

@CalvinKirs
Copy link
Member

How about change seatunnel-connectors-flink,seatunnel-connectors-spark,seatunnel-connectors-seatunnel to flink,spark,seatunnel? Because they are seatunnel-connectors's sub module. @ruanwenjun @CalvinKirs

How about we separate out the seatunnel-connector? In our later planning, it seems that the separate connector support of flink or spark will be gradually abandoned.

@EricJoy2048
Copy link
Member Author

How about change seatunnel-connectors-flink,seatunnel-connectors-spark,seatunnel-connectors-seatunnel to flink,spark,seatunnel? Because they are seatunnel-connectors's sub module. @ruanwenjun @CalvinKirs

How about we separate out the seatunnel-connector? In our later planning, it seems that the separate connector support of flink or spark will be gradually abandoned.

Do you mean we move flink-connector, spark-connector, seatunnel-connector to the first level module?

@ashulin
Copy link
Member

ashulin commented Jun 28, 2022

Are we only changing seatunnel-connector to the first level module?

@CalvinKirs
Copy link
Member

Are we only changing seatunnel-connector to the first level module?

Just split the new connector into a first-level module. (because it has nothing to do with the engine)

@EricJoy2048
Copy link
Member Author

EricJoy2048 commented Jun 28, 2022 •
edited
Loading

Are we only changing seatunnel-connector to the first level module?

Just split the new connector into a first-level module. (because it has nothing to do with the engine)

Ok, what's the name of the first-level module? How about seatunnel-connectors-v2?

@EricJoy2048
Copy link
Member Author

EricJoy2048 commented Jun 28, 2022 •
edited
Loading

Another question, what is the module name seatunnel-connector-seatunnel-clickhouse will be update to?
What about connector-clickhouse ?

@Hisoka-X
Copy link
Member

Another question, what is the module name seatunnel-connector-seatunnel-clickhouse will be update to? What about connector-clickhouse ?

how about clickhouse-connector?

@CalvinKirs
Copy link
Member

Another question, what is the module name seatunnel-connector-seatunnel-clickhouse will be update to? What about connector-clickhouse ?

how about clickhouse-connector?

+1

@EricJoy2048 EricJoy2048 reopened this Jun 28, 2022
@EricJoy2048
Copy link
Member Author

link #1946

@CalvinKirs CalvinKirs merged commit f79e311 into apache:api-draft Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricJoy2048 @Hisoka-X @CalvinKirs @ashulin