[Connector-V2] Add File Sink Connector #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
previously approved these changes
Jul 5, 2022
There was a problem hiding this comment.
LGTM, the LICENSE file need to confirm, I think we still added some extra item in LICENSE file. cc @CalvinKirs
CalvinKirs
reviewed
Jul 5, 2022
pom.xml
Outdated
Comment on lines
157
to
158
| <commons-collections.version>3.2.2</commons-collections.version> | ||
| <commons-collections4.version>4.4</commons-collections4.version> |
There was a problem hiding this comment.
why did we need to add this?We already have collection4
CalvinKirs
reviewed
Jul 5, 2022
.idea/vcs.xml
Outdated
Comment on lines
1
to
21
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ Licensed to the Apache Software Foundation (ASF) under one or more | ||
| ~ contributor license agreements. See the NOTICE file distributed with | ||
| ~ this work for additional information regarding copyright ownership. | ||
| ~ The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| ~ (the "License"); you may not use this file except in compliance with | ||
| ~ the License. You may obtain a copy of the License at | ||
| ~ | ||
| ~ http://www.apache.org/licenses/LICENSE-2.0 | ||
| ~ | ||
| ~ Unless required by applicable law or agreed to in writing, software | ||
| ~ distributed under the License is distributed on an "AS IS" BASIS, | ||
| ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| ~ See the License for the specific language governing permissions and | ||
| ~ limitations under the License. | ||
| --> | ||
| <project version="4"> | ||
| <component name="VcsDirectoryMappings"> | ||
| <mapping directory="$PROJECT_DIR$" vcs="Git" /> | ||
| </component> |
CalvinKirs
reviewed
Jul 5, 2022
Comment on lines
558
to
+563
| metrics-core-3.2.1.jar | ||
| metrics-core-4.0.0.jar | ||
| metrics-json-3.1.0.jar | ||
| metrics-json-3.1.5.jar | ||
| metrics-jvm-3.1.0.jar | ||
| metrics-jvm-3.1.5.jar |
There was a problem hiding this comment.
We'd better unify the version to facilitate subsequent maintenance. I've been doing something related recently.
There was a problem hiding this comment.
You have a lot of unnecessary formatting changes, please revert it.
There was a problem hiding this comment.
This is not dependency by my pr.
Hisoka-X
previously approved these changes
Jul 6, 2022
Hisoka-X
approved these changes
Jul 7, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link #1946