[Feat][UI] Add theme-related configuration. #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinKirs
reviewed
Jul 6, 2022
| import { throttle } from 'echarts' | ||
| import { useI18n } from 'vue-i18n' | ||
| import type { Ref } from 'vue' | ||
| import type { ECharts } from 'echarts' |
There was a problem hiding this comment.
did we need add echarts license file?
There was a problem hiding this comment.
I would say no. don't say like DS, we are still in the incubator, I believe that any project will strictly require a license.
Amy0104
reviewed
Jul 6, 2022
| () => { | ||
| chart?.dispose() | ||
| init() | ||
| } |
There was a problem hiding this comment.
Why not put the chart.dipose() into the init function?
zhongjiajie
approved these changes
Jul 6, 2022
|
cc @songjianet @Amy0104 It seems currently we do not need run all ci in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #2135
Check list
New License Guide