[Connector-V2] Add Email sink connector #2304
Conversation
add kudu dependency
add kudu config
add kudu
|
Hi, please resolve ci error first. Thanks |
|
If any new Jar binary package adding in your PR, please add License Notice according |
| createFile(); | ||
| Properties properties = new Properties(); | ||
|
|
||
| properties.setProperty("mail.host", "smtp.qq.com"); |
There was a problem hiding this comment.
This parameter should be handed over to user control
| properties.setProperty("mail.transport.protocol", "smtp"); | ||
|
|
||
| properties.setProperty("mail.smtp.auth", "true"); |
There was a problem hiding this comment.
Same problem as above, and these methods may not be appropriate in close method
| public void write(SeaTunnelRow element) { | ||
| Object[] fields = element.getFields(); | ||
|
|
||
| for (Object field : fields) { | ||
| stringBuffer.append(field.toString() + ","); | ||
| } | ||
| stringBuffer.deleteCharAt(fields.length - 1); |
There was a problem hiding this comment.
just as a suggestion. (You can improve it in the next PR, we need to consider the format of various formats, for email)
There was a problem hiding this comment.
ok,What file formats would you like to have in the future? PDF?
|
Hi, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs |
done; |
docs/en/connector-v2/source/Email.md
Outdated
|
|
||
| Send the data as a file to email. | ||
|
|
||
| The tested kudu version is 1.5.6. |
docs/en/connector-v2/source/Email.md
Outdated
| email_transport_protocol="smtp" | ||
| email_smtp_auth="true" | ||
| email_authorization_code="" | ||
| email_message_headline="这个是标题" |
* 0 * Update pom.xml add kudu dependency * Update plugin-mapping.properties add kudu config * Update pom.xml add kudu * add email sink connector * Delete seatunnel-connectors-v2/connector-email directory * Update plugin-mapping.properties * Update plugin-mapping.properties * Update pom.xml * Create pom.xml * [Connector-V2] Add Kudu source and sink connector * [Connector-V2] Add Kudu source and sink connector * [Connector-V2] Add Email sink connector * Update pom.xml * Update pom.xml * Delete seatunnel-connectors-v2/connector-kudu directory * Update pom.xml * Update plugin-mapping.properties * Update pom.xml * [Connector-V2] update codestyle pom.xml * [Connector-V2] update config * [Connector-V2] update license * [Connector-V2] update email package version 1.5.6 * [Connector-V2] fix problem on code review * [Connector-V2] add Email usage document * Update Email.md
Purpose of this pull request
Check list
New License Guide