Add jdbc connector e2e test #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2255 . License it's ok. I will take a look when my free. |
3 tasks
ic4y
reviewed
Aug 12, 2022
| while (resultSet.next()) { | ||
| result.add(resultSet.getString("name")); | ||
| } | ||
| Assertions.assertFalse(result.isEmpty()); |
There was a problem hiding this comment.
Only check is not isEmpty that is not accurate.
There was a problem hiding this comment.
Yes, we need to do data quality check.
|
@zhangyuge1 Thank you for your contribution. At present, only batch tests are covered, Streaming Mode and Exactly-Once Streaming Mode are not covered。Can you add these two test scenarios? And abstract public methods for use by mysql, pgsql, and dmsql . . . |
This was referenced Aug 15, 2022
ruanwenjun
approved these changes
Aug 15, 2022
CalvinKirs
approved these changes
Aug 15, 2022
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Sep 18, 2022
* add jdbc e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide