Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-v2] Neo4j sink connector #2434

Merged
merged 10 commits into from
Aug 19, 2022
Merged

[Feature][Connector-v2] Neo4j sink connector #2434

merged 10 commits into from
Aug 19, 2022

Conversation

getChan
Copy link
Contributor

@getChan getChan commented Aug 16, 2022 •
edited
Loading

Purpose of this pull request

To add Neo4j Sink Connector

Check list

CalvinKirs
CalvinKirs reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, could you add the license header?

@getChan
Copy link
Contributor Author

getChan commented Aug 17, 2022

hi, could you add the license header?

oh. done.

EricJoy2048
EricJoy2048 reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your contribute. I think Neo4j Sink can support 2PC submit, If you are interested, you can implement it in the future.

CalvinKirs
CalvinKirs reviewed Aug 17, 2022
View reviewed changes
seatunnel-connectors-v2/connector-neo4j/pom.xml Outdated
<dependency>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver</artifactId>
<version>4.4.9</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We manage versions uniformly in the root pom

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it

CalvinKirs
CalvinKirs reviewed Aug 17, 2022
View reviewed changes
...-neo4j/src/main/java/org/apache/seatunnel/connectors/seatunnel/neo4j/config/Neo4jConfig.java Outdated
@Setter
public class Neo4jConfig implements Serializable {

public static final String KEY_SINK_PLUGIN_NAME = "Neo4jSink";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better used Neo4j

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it

@CalvinKirs CalvinKirs merged commit 950b27d into apache:dev Aug 19, 2022
@CalvinKirs
Copy link
Member

Thanks for your contribution. looking forward you next PR:)

@getChan getChan mentioned this pull request Aug 20, 2022
Closed
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
@getChan @TyrantLucifer
[Feature][Connector-v2] Neo4j sink connector (apache#2434)
9ccc776 
* ConnectorV2 - Neo4j Sink
@EricJoy2048 EricJoy2048 mentioned this pull request Oct 8, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 left review comments

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees
No one assigned
Labels
connectors-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@getChan @CalvinKirs @EricJoy2048