-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][e2e] refactor jupiter,add junit-jupiter-api #2662
Conversation
Can you explain why you want to add this dependency? |
the e2e module used junit 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have declared these dependencies, junit-jupiter-params
inculde juitper-api
if you checked. e2e We use junit4 and 5 for Testcontainers
reasons
but the e2e dependence |
This PR contains the reason: #2672 . I ran CI again. |
hi, we better revert https://github.com/apache/incubator-seatunnel/blob/34ccfd7a2cd93d8dc0d3f6bb1e1afebcc9761a9e/pom.xml#L360 |
My suggestion is to introduce junit-bom for dependency management and remove add:
remote:
update:
|
UserControllerTest executes an error after the scheduler function is added to the web module, because the web module needs to connect to the dolphinscheduler server, I will deal with this problem. |
afe38d6
to
6068b82
Compare
Co-authored-by: CalvinKirs <kirs@apache.org> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
Co-authored-by: CalvinKirs <kirs@apache.org> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
Co-authored-by: CalvinKirs <kirs@apache.org> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
Co-authored-by: CalvinKirs <kirs@apache.org> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
Co-authored-by: CalvinKirs <kirs@apache.org> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
Co-authored-by: CalvinKirs <kirs@apache.org> Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
Purpose of this pull request
refactor jupiter,add junit-jupiter-api
Check list
New License Guide