[Improve][e2e] Container only copy required connector jars #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashulin
changed the title
3 tasks
|
PTAL, thanks. @ruanwenjun @hailin0 @laglangyue |
# Conflicts: # seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-spark-e2e-base/src/test/java/org/apache/seatunnel/e2e/spark/SparkContainer.java
hailin0
reviewed
Sep 9, 2022
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/ContainerUtil.java
Outdated
Show resolved
Hide resolved
...el-flink-e2e-common/src/test/java/org/apache/seatunnel/e2e/flink/AbstractFlinkContainer.java
Outdated
Show resolved
Hide resolved
...el-flink-e2e-common/src/test/java/org/apache/seatunnel/e2e/flink/AbstractFlinkContainer.java
Outdated
Show resolved
Hide resolved
...ctor-flink-sql-e2e-base/src/test/java/org/apache/seatunnel/e2e/flink/sql/FlinkContainer.java
Outdated
Show resolved
Hide resolved
|
LGTM |
CalvinKirs
approved these changes
Sep 9, 2022
laglangyue
pushed a commit
to laglangyue/seatunnel
that referenced
this pull request
Sep 11, 2022
* [Improve][e2e] flink container only copy required connector jars * rename flink-e2e-common * remove useless imported * [Improve][e2e] flink sql container refactoring * remove useless imported * remove useless * [Improve][e2e] spark container only copy required connector jars * change for code review * Use e2e-common module directly * checkstyle * code format
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Sep 13, 2022
* [Improve][e2e] flink container only copy required connector jars * rename flink-e2e-common * remove useless imported * [Improve][e2e] flink sql container refactoring * remove useless imported * remove useless * [Improve][e2e] spark container only copy required connector jars * change for code review * Use e2e-common module directly * checkstyle * code format
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 16, 2022
* [Improve][e2e] flink container only copy required connector jars * rename flink-e2e-common * remove useless imported * [Improve][e2e] flink sql container refactoring * remove useless imported * remove useless * [Improve][e2e] spark container only copy required connector jars * change for code review * Use e2e-common module directly * checkstyle * code format
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Sep 18, 2022
* [Improve][e2e] flink container only copy required connector jars * rename flink-e2e-common * remove useless imported * [Improve][e2e] flink sql container refactoring * remove useless imported * remove useless * [Improve][e2e] spark container only copy required connector jars * change for code review * Use e2e-common module directly * checkstyle * code format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide