Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Starter] [Core] Modify connector v2 starter #2726

Merged
merged 5 commits into from
Sep 14, 2022

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Sep 14, 2022

Purpose of this pull request

Modify connector v2 starter and remove spark/flink in seatunnel-core-starter
SubTask for #2690

Check list

hailin0
hailin0 previously approved these changes Sep 14, 2022
ashulin
ashulin previously approved these changes Sep 14, 2022
# Conflicts:
#	seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkExecution.java
#	seatunnel-core/seatunnel-spark-starter/src/main/java/org/apache/seatunnel/core/starter/spark/execution/SparkExecution.java
@Hisoka-X Hisoka-X dismissed stale reviews from ashulin and hailin0 via 116dd5f September 14, 2022 08:45
@Hisoka-X
Copy link
Member Author

@ashulin @hailin0 Hi, Please check again, thanks!

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 547a6be into apache:dev Sep 14, 2022
@Hisoka-X Hisoka-X deleted the dev-starter branch September 15, 2022 03:50
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 16, 2022
* [Starter] [Core] Modify connector v2 starter and remove spark/flink in seatunnel-core-starter
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
* [Starter] [Core] Modify connector v2 starter and remove spark/flink in seatunnel-core-starter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants