[Feature][Connector-V2] Jdbc connector support SAP HANA Source & SAP HANA Sink. #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it necessary to have init-datasource as a separate file?I think the paperwork is getting a little messy,How about writing it straight into code? |
3 tasks
Nice thought. |
FlechazoW
force-pushed
the
dev
branch
2 times, most recently
from
47f8040
to
63a6cd4
Compare
|
The code style should be fixed. |
Done @Hisoka-X |
FlechazoW
force-pushed
the
dev
branch
2 times, most recently
from
2711ae9
to
40c8dab
Compare
|
@FlechazoW The Integration Test have some problems should be fixed. |
FlechazoW
force-pushed
the
dev
branch
3 times, most recently
from
61d251d
to
b4b9dc6
Compare
hailin0
reviewed
Oct 12, 2022
...tor-jdbc-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcSapHanaIT.java
Outdated
Show resolved
Hide resolved
FlechazoW
force-pushed
the
dev
branch
2 times, most recently
from
55473c2
to
a86f227
Compare
|
trigger CI |
EricJoy2048
changed the title
FlechazoW
force-pushed
the
dev
branch
3 times, most recently
from
e6ed84f
to
e354ea7
Compare
ic4y
reviewed
Nov 1, 2022
| case SAP_HANA_REAL: | ||
| case SAP_HANA_SMALLDECIMAL: | ||
| return BasicType.FLOAT_TYPE; | ||
| case SAP_HANA_BIGINT: |
There was a problem hiding this comment.
SAP_HANA_BIGINT can be use BasicType.LONG_TYPE
| return BasicType.FLOAT_TYPE; | ||
| case SAP_HANA_BIGINT: | ||
| case SAP_HANA_INTEGER: | ||
| case SAP_HANA_SMALLINT: |
There was a problem hiding this comment.
SAP_HANA_SMALLINT -> BasicType.SHORT_TYPE
| case SAP_HANA_BIGINT: | ||
| case SAP_HANA_INTEGER: | ||
| case SAP_HANA_SMALLINT: | ||
| case SAP_HANA_TINYINT: |
There was a problem hiding this comment.
SAP_HANA_TINYINT -> BasicType.BYTE_TYPE
FlechazoW
force-pushed
the
dev
branch
2 times, most recently
from
795eae8
to
6cb0b51
Compare
Hisoka-X
previously approved these changes
Nov 14, 2022
|
Are |
liugddx
approved these changes
Jan 2, 2023
...g/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeMapper.java
Show resolved
Hide resolved
...g/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeMapper.java
Show resolved
Hide resolved
...g/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/saphana/SapHanaTypeMapper.java
Show resolved
Hide resolved
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Connector-V2][JDBC-connector] support Jdbc dm
Check list
New License Guide