-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Kylin source connector #3116
Conversation
switch (kylinType) { | ||
case KYLIN_BOOLEAN: | ||
return BasicType.BOOLEAN_TYPE; | ||
case KYLIN_TINYINT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have short
type maybe you can use it to represent tinyint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have
short
type maybe you can use it to representtinyint
thinks your good advice,i have fixed it in new commit
Since need to configure the kylin cube model and build the data in the kylin UI to complete the data preparation, it seems that you cannot add e2e to the program. so I added a tips to describe this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @ic4y PTAL.
Please fix the CI problems. |
|
Please add e2e test |
|
Got it, if e2e testing is very difficult. You can comment below your local testing process in the form of pictures, etc. This will make it easier to troubleshoot later if there is a problem. |
@@ -100,6 +100,7 @@ there are some reference value for params above. | |||
| oracle | oracle.jdbc.OracleDriver | jdbc:oracle:thin:@localhost:1521/xepdb1 | https://mvnrepository.com/artifact/com.oracle.database.jdbc/ojdbc8 | | |||
| gbase8a | com.gbase.jdbc.Driver | jdbc:gbase://e2e_gbase8aDb:5258/test | https://www.gbase8.cn/wp-content/uploads/2020/10/gbase-connector-java-8.3.81.53-build55.5.7-bin_min_mix.jar | | |||
| starrocks | com.mysql.cj.jdbc.Driver | jdbc:mysql://localhost:3306/test | https://mvnrepository.com/artifact/mysql/mysql-connector-java | | |||
| kylin | org.apache.kylin.jdbc.Driver | jdbc:kylin://localhost:7070/kylin_project_name | https://mvnrepository.com/artifact/org.apache.kylin/kylin-jdbc| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changed log
reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
Purpose of this pull request
refer to #3018
add Kylin source Connector
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types
https://kylin.apache.org/cn/docs31/howto/howto_jdbc.html
tips
Tip: Since need to configure the kylin cube model and build the data in the kylin UI to complete the data preparation, it seems that you cannot add e2e to the program. refer to https://kylin.apache.org/cn/docs/tutorial/create_cube.html
Check list
New License Guide