Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] Kylin source connector #3116

Closed
wants to merge 6 commits into from

Conversation

531651225
Copy link
Contributor

@531651225 531651225 commented Oct 17, 2022

Purpose of this pull request

refer to #3018
add Kylin source Connector

tips

Tip: Since need to configure the kylin cube model and build the data in the kylin UI to complete the data preparation, it seems that you cannot add e2e to the program. refer to https://kylin.apache.org/cn/docs/tutorial/create_cube.html
图片

Check list

switch (kylinType) {
case KYLIN_BOOLEAN:
return BasicType.BOOLEAN_TYPE;
case KYLIN_TINYINT:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have short type maybe you can use it to represent tinyint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have short type maybe you can use it to represent tinyint

thinks your good advice,i have fixed it in new commit

@Hisoka-X
Copy link
Member

@531651225
Copy link
Contributor Author

Please add e2e in https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e

Since need to configure the kylin cube model and build the data in the kylin UI to complete the data preparation, it seems that you cannot add e2e to the program. so I added a tips to describe this

Hisoka-X
Hisoka-X previously approved these changes Oct 18, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ic4y PTAL.

TaoZex
TaoZex previously approved these changes Oct 20, 2022
@531651225 531651225 dismissed stale reviews from TaoZex and Hisoka-X via 5d1511c October 20, 2022 05:42
@EricJoy2048
Copy link
Member

Please fix the CI problems.

@531651225
Copy link
Contributor Author

Please fix the CI problems.
thinks, i have fix it. PTAL.

@ic4y
Copy link
Contributor

ic4y commented Oct 25, 2022

Please add e2e test

@531651225
Copy link
Contributor Author

Please add e2e test
Since need to configure the kylin cube model and build the data in the kylin UI to complete the data preparation, it seems that you cannot add e2e to the program. so I added a tips to describe this

@ic4y
Copy link
Contributor

ic4y commented Oct 25, 2022

Please add e2e test
Since need to configure the kylin cube model and build the data in the kylin UI to complete the data preparation, it seems that you cannot add e2e to the program. so I added a tips to describe this

Got it, if e2e testing is very difficult. You can comment below your local testing process in the form of pictures, etc. This will make it easier to troubleshoot later if there is a problem.

@@ -100,6 +100,7 @@ there are some reference value for params above.
| oracle | oracle.jdbc.OracleDriver | jdbc:oracle:thin:@localhost:1521/xepdb1 | https://mvnrepository.com/artifact/com.oracle.database.jdbc/ojdbc8 |
| gbase8a | com.gbase.jdbc.Driver | jdbc:gbase://e2e_gbase8aDb:5258/test | https://www.gbase8.cn/wp-content/uploads/2020/10/gbase-connector-java-8.3.81.53-build55.5.7-bin_min_mix.jar |
| starrocks | com.mysql.cj.jdbc.Driver | jdbc:mysql://localhost:3306/test | https://mvnrepository.com/artifact/mysql/mysql-connector-java |
| kylin | org.apache.kylin.jdbc.Driver | jdbc:kylin://localhost:7070/kylin_project_name | https://mvnrepository.com/artifact/org.apache.kylin/kylin-jdbc|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Mar 17, 2023
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants