[Hotfix][OptionRule] Fix option rule about all connectors #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashulin
reviewed
Nov 28, 2022
Comment on lines
-165
to
-170
| /** | ||
| * Conditional options, These options are required if the {@link Option} == expectValue. | ||
| */ | ||
| public <T> Builder conditional(Option<T> option, T expectValue, Option<?>... requiredOptions) { | ||
| return conditional(Condition.of(option, expectValue), requiredOptions); | ||
| } |
There was a problem hiding this comment.
IMO, The tool method of a single expected value need not be deleted.
There was a problem hiding this comment.
IMO, The tool method of a single expected value need not be deleted.
Ok.
Comment on lines
168
to
174
| public Builder exclusive(@NonNull RequiredOption.ExclusiveRequiredOptions exclusiveRequiredOptions) { | ||
| exclusiveRequiredOptions.getExclusiveOptions().forEach(option -> { | ||
| verifyDuplicate(option, "ExclusiveOption"); | ||
| }); | ||
| this.requiredOptions.add(exclusiveRequiredOptions); | ||
| return this; | ||
| } |
CalvinKirs
approved these changes
Nov 29, 2022
Hisoka-X
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.