[Feature][Connector V2] Add GoogleSheets Sink #3848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have permission to update this pr:#3411 |
CalvinKirs
requested changes
Jan 3, 2023
Thanks for your advice. I will add e2e test code. |
3 tasks
EricJoy2048
reviewed
Jan 31, 2023
...main/java/org/apache/seatunnel/connectors/seatunnel/google/sheets/sink/SheetsSinkWriter.java
Outdated
Show resolved
Hide resolved
|
@EricJoy2048 I have resolved conflict. PTAL. |
TyrantLucifer
requested changes
Feb 27, 2023
|
|
||
| > GoogleSheets sink connector | ||
| > | ||
| ## Description |
| sourceCredentials.createScoped( | ||
| Collections.singletonList(SheetsScopes.SPREADSHEETS)); | ||
| HttpRequestInitializer requestInitializer = new HttpCredentialsAdapter(sourceCredentials); | ||
| NetHttpTransport httpTransport = null; |
There was a problem hiding this comment.
Suggested change
| NetHttpTransport httpTransport = null; | |
| NetHttpTransport httpTransport; |
| } | ||
|
|
||
| @Override | ||
| public String getErrorMessage() { |
|
Offser the snapshot images of this connectors in different engines (flink spark zeta), not the snapshot images of seatunnel-examples, you need compile it and run test cases in integration test env. |
|
waitting ci |
|
LGTM |
hailin0
approved these changes
May 22, 2023
TyrantLucifer
requested changes
May 22, 2023
| fields { | ||
| name = "string" | ||
| address = "string" | ||
| age = "int" |
|
Any process this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
improve pr : #3411
Check list
New License Guide