Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2][File] Support compress #3899

Merged
merged 5 commits into from
Jan 16, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

close #3839

Check list

@TyrantLucifer TyrantLucifer marked this pull request as draft January 9, 2023 08:03
@TaoZex
Copy link
Contributor

TaoZex commented Jan 9, 2023

Add e2e test may be better.

@TyrantLucifer TyrantLucifer marked this pull request as ready for review January 14, 2023 15:11
CalvinKirs
CalvinKirs previously approved these changes Jan 16, 2023
@TaoZex
Copy link
Contributor

TaoZex commented Jan 16, 2023

Please resolve the conflict.

@@ -157,6 +158,16 @@ Only support `true` now.

The maximum number of rows in a file. For SeaTunnel Engine, the number of lines in the file is determined by `batch_size` and `checkpoint.interval` jointly decide. If the value of `checkpoint.interval` is large enough, sink writer will write rows in a file until the rows in the file larger than `batch_size`. If `checkpoint.interval` is small, the sink writer will create a new file when a new checkpoint trigger.

### compress_codec [string]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add change log?

@EricJoy2048 EricJoy2048 merged commit 55602f6 into apache:dev Jan 16, 2023
harveyyue pushed a commit to harveyyue/seatunnel that referenced this pull request Feb 7, 2023
* [Feature][Connector-V2][File] Support compress

* [Feature][Connector-V2][File] Update e2e tests

* [Feature][Connector-V2][File] Update docs

* [Improve][Connector-V2][File] Update docs

* [Improve][Connector-V2][File] Update option rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-V2][File] Support compress codec
4 participants