-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2][File] Support compress #3899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add e2e test may be better. |
CalvinKirs
previously approved these changes
Jan 16, 2023
Please resolve the conflict. |
TyrantLucifer
force-pushed
the
support-compress
branch
from
January 16, 2023 13:35
ba8f010
to
5bf9858
Compare
CalvinKirs
approved these changes
Jan 16, 2023
EricJoy2048
approved these changes
Jan 16, 2023
@@ -157,6 +158,16 @@ Only support `true` now. | |||
|
|||
The maximum number of rows in a file. For SeaTunnel Engine, the number of lines in the file is determined by `batch_size` and `checkpoint.interval` jointly decide. If the value of `checkpoint.interval` is large enough, sink writer will write rows in a file until the rows in the file larger than `batch_size`. If `checkpoint.interval` is small, the sink writer will create a new file when a new checkpoint trigger. | |||
|
|||
### compress_codec [string] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add change log?
harveyyue
pushed a commit
to harveyyue/seatunnel
that referenced
this pull request
Feb 7, 2023
* [Feature][Connector-V2][File] Support compress * [Feature][Connector-V2][File] Update e2e tests * [Feature][Connector-V2][File] Update docs * [Improve][Connector-V2][File] Update docs * [Improve][Connector-V2][File] Update option rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #3839
Check list
New License Guide
release-note
.