-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support avro format #5084
Conversation
pls re-trigger the CI, no failed job, only one cancelled job |
Run |
can we retrigger the CI as we has fix the code style error |
d7d8610
to
1a6426b
Compare
...e/connector-paimon-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/PaimonIT.java
Outdated
Show resolved
Hide resolved
run successful when disable on flink 1.15 https://github.com/liunaijie/seatunnel/actions/runs/5617980130 |
merge the conflict, pls re-trigger the CI |
https://github.com/liunaijie/seatunnel/actions/runs/5676004114/job/15382134463 |
@liunaijie Great commit! Now we just need to resolve the conflicts. |
7498907
to
64fb875
Compare
- added avro format and UT - kafka support avro format and e2e test Signed-off-by: Jarvis <liunaijie1996@163.com>
53619ad
to
cf800c9
Compare
# Conflicts: # seatunnel-connectors-v2/connector-kafka/pom.xml # seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/config/MessageFormat.java # seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java # seatunnel-formats/pom.xml
this pr always failed with PaimonIT, and this pr #5419 has fixed this issue, once this issue merged, pls re-trigger the CI, thanks. |
c90a897
to
510bf8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liunaijie
good pr, please fix the conflict
# Conflicts: # seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSource.java
@hailin0 Done. PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pr, I learned something new from it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add NOTICE file https://github.com/apache/avro/blob/main/NOTICE.txt
at https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/release-docs/NOTICE
...nnel-format-avro/src/main/java/org/apache/seatunnel/format/avro/AvroSerializationSchema.java
Outdated
Show resolved
Hide resolved
055eb4c
to
426020e
Compare
426020e
to
4c05290
Compare
# Conflicts: # seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/config/MessageFormat.java # seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkFactory.java # tools/dependencies/known-dependencies.txt
SEATUNNEL_ROW_TYPE, | ||
MessageFormat.AVRO, | ||
DEFAULT_FIELD_DELIMITER); | ||
generateTestData(row -> serializer.serializeRow(row), 0, 100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do this by adding e2e uniformly to All formats are integrated in this
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaFormatIT.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @zhilinli123, i use a method in KafkaIT
and also KafKaIT
has other format e2e test like json, text. so i don't want move to KafkaFormatIT
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need update notice file
https://github.com/apache/avro/blob/release-1.11.1/NOTICE.txt
Basically LGTM, wait ci pass |
@ruanwenjun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi I found some issues in kafka avro e2e testing. My configuration is as follows
|
Purpose of this pull request
close #4821
same pr with #5064
Check list
New License Guide
release-note
.