Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature-WIP][Connector-V2][Doris] Add Doris ConnectorV2 Source #5086

Closed
wants to merge 20 commits into from
Closed

[Feature-WIP][Connector-V2][Doris] Add Doris ConnectorV2 Source #5086

wants to merge 20 commits into from

Conversation

bingquanzhao
Copy link
Contributor

Purpose of this pull request

Check list

@davidzollo davidzollo added the First-time contributor First-time contributor label Jul 16, 2023
@bingquanzhao bingquanzhao marked this pull request as ready for review July 20, 2023 08:39
@EricJoy2048
Copy link
Member

Please fix code style. you can use sh tools/spotless_check/pre-commit.sh

@bingquanzhao
Copy link
Contributor Author

Please fix code style. you can use sh tools/spotless_check/pre-commit.sh

Done

@ic4y
Copy link
Contributor

ic4y commented Aug 5, 2023

org.apache.seatunnel.e2e.connector.doris.DorisIT.testDoris has failed. It needs to be addressed.

CalvinKirs
CalvinKirs previously approved these changes Aug 5, 2023
View reviewed changes
@CalvinKirs
Copy link
Member

pls check you docs styke

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Aug 23, 2023
@EricJoy2048 EricJoy2048 reopened this Oct 26, 2023
EricJoy2048
EricJoy2048 previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait Doris catalog pr merge and then use Catalog to refactor the functionality of this connector.

@EricJoy2048 EricJoy2048 dismissed their stale review October 26, 2023 09:01

Please wait Doris catalog pr merge and then use Catalog to refactor the functionality of this connector.

@dzygoon
Copy link
Contributor

dzygoon commented Jan 4, 2024

why this commit not be merged? when doris source can be integration? thks.

@Hisoka-X
Copy link
Member

Hisoka-X commented Jan 4, 2024

why this commit not be merged? when doris source can be integration? thks.

Hi @dzygoon , this pr is working in process. After it ready, we can start review it. Then merge it.

@dzygoon
Copy link
Contributor

dzygoon commented Jan 4, 2024

why this commit not be merged? when doris source can be integration? thks.

Hi @dzygoon , this pr is working in process. After it ready, we can start review it. Then merge it.

Okay.

@EricJoy2048 EricJoy2048 removed this from the 2.3.4 milestone Jan 8, 2024
@EricJoy2048
Copy link
Member

Hi, @bingquanzhao This pr is duplicated with #6161. I will close this pr.

Thanks from your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X left review comments

@EricJoy2048 EricJoy2048 EricJoy2048 left review comments

@CalvinKirs CalvinKirs CalvinKirs left review comments

Assignees
No one assigned
Labels
First-time contributor First-time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bingquanzhao @EricJoy2048 @ic4y @CalvinKirs @dzygoon @Hisoka-X @davidzollo