[Feature][CDC] Support for preferring numeric fields as split keys #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good |
ic4y
reviewed
Sep 1, 2023
Comment on lines
374
to
376
| if (splitColumn != null) { | ||
| return splitColumn; | ||
| } |
There was a problem hiding this comment.
Remove this, would it be better to also include Unique Keys in the comparison?
EricJoy2048
reviewed
Sep 26, 2023
| @@ -30,6 +30,7 @@ | |||
|
|
|||
| <properties> | |||
| <hikaricp.version>4.0.3</hikaricp.version> | |||
| <junit.vserion>4.13.2</junit.vserion> | |||
There was a problem hiding this comment.
Why not use junit 5.9.0 define in root pom.xml?
There was a problem hiding this comment.
Currently, a large number of tests are used for this version
EricJoy2048
approved these changes
Sep 26, 2023
ic4y
approved these changes
Sep 27, 2023
gnehil
pushed a commit
to gnehil/seatunnel
that referenced
this pull request
Oct 12, 2023
…pache#5384) * [Feature][CDC] Support for preferring numeric fields as split keys --------- Co-authored-by: zhouyao <yao.zhou@marketingforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
colse #5156
Check list
New License Guide
release-note.