-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] update iotdb document #5404
Conversation
@hailin0 PTAL |
Hi @liunaijie Would you like to contribute v2.0 documentation to the Iotdb connector? I look forward to your contribution |
sure |
LGTM, it's better to use v2.0 doc style as @zhilinli123 said. |
|
||
Upstream SeaTunnelRow data format is the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sink example, I only add 1 case (fakesource to iotdb)(also 1 case in source example, use iotdb to console)
the key_timestamp is optional, so i remove it.
for example data, remove some filed to keep consistent with example code.
key_device = "device_name" | ||
key_timestamp = "ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete?
``` | ||
|
||
Upstream SeaTunnelRow data format is the following: | ||
|
||
| ts | device_name | field_1 | field_2 | temperature | moisture | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whl update ?
@hailin0 when i update the doc, i find in source, node_url is required, and host, port is optional. but they all represent same thing. |
We hope that there should be more examples in the document to demonstrate the scenarios in which different parameters are used. In general, we recommend at least three examples. |
f9e166c
to
06028ad
Compare
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks contribution PTAL: @EricJoy2048 |
* [Doc] update iotdb document, remove duplicated config * [Doc] update iotdb document * [Doc] update iotdb document
* [Doc] update iotdb document, remove duplicated config * [Doc] update iotdb document * [Doc] update iotdb document
* [Doc] update iotdb document, remove duplicated config * [Doc] update iotdb document * [Doc] update iotdb document
Purpose of this pull request
Check list
New License Guide
release-note
.