Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Change class name of AbstractJobEnvironment implement #5671

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR change JobExecutionEnvironment to ClientJobExecutionEnvironment, change JobImmutableInformationEnv to RestJobExecutionEnvironment. To make sure the meaning of class name is more clear.

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test.

Check list

@Hisoka-X
Copy link
Member Author

cc @liugddx @zhibinF

@Hisoka-X Hisoka-X changed the title [Improve] Change class name for AbstractJobEnvironment implement [Improve] Change class name of AbstractJobEnvironment implement Oct 20, 2023
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liugddx liugddx merged commit 83082b2 into apache:dev Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants