[Improve][Zeta] Add restore when commit failed #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
previously approved these changes
Jan 2, 2024
|
What test case can verify it? |
adding |
Could you please offer the details? |
I'm adding test case, after it ready, I will push to this PR branch. |
|
I added new test to cover this. PTAL @TyrantLucifer @hailin0 @TaoZex @EricJoy2048 |
EricJoy2048
approved these changes
Jan 8, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
* [Improve][Zeta] Add restore when commit failed * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR change the behavior of commit failed. We should retry job as usual.
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test
Check list
New License Guide
release-note.