[bugFix][Connector-V2][CDC] SeaTunnelRowDebeziumDeserializationConverters NPE #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
previously approved these changes
Jul 7, 2024
Hisoka-X
reviewed
Jul 7, 2024
| @@ -184,7 +184,7 @@ private void deserializeDataChangeRecord(SourceRecord record, Collector<SeaTunne | |||
| delete.setRowKind(RowKind.DELETE); | |||
| delete.setTableId(tableId); | |||
| collector.collect(delete); | |||
| } else { | |||
| } else if (operation == Envelope.Operation.UPDATE) { | |||
There was a problem hiding this comment.
In addition to update related statements, are there any other statements that can reach the else block?
There was a problem hiding this comment.
Yes, we should ignore it. cc @hailin0
Hisoka-X
approved these changes
Jul 8, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 10, 2024
Thomas-HuWei
pushed a commit
to zilliztech/seatunnel
that referenced
this pull request
Jul 10, 2024
Thomas-HuWei
pushed a commit
to zilliztech/seatunnel
that referenced
this pull request
Jul 10, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 13, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #6901
ref #7113
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.