[Feature][Doris] Support multi-table source read #7895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2024 22:52
added 4 commits
October 23, 2024 23:01
hailin0
reviewed
Oct 24, 2024
| @@ -16,6 +16,7 @@ | |||
| - [x] [schema projection](../../concept/connector-v2-features.md) | |||
| - [x] [parallelism](../../concept/connector-v2-features.md) | |||
| - [x] [support user-defined split](../../concept/connector-v2-features.md) | |||
| - [x] [support multiple table read](../../concept/connector-v2-features.md) | |||
There was a problem hiding this comment.
update cn docs
done.
Hisoka-X
reviewed
Oct 25, 2024
| DorisSourceTable dorisSourceTable = | ||
| tables.get(TablePath.of(partition.getDatabase(), partition.getTable())); | ||
| if (dorisSourceTable == null) { | ||
| return; |
There was a problem hiding this comment.
I think we should throw exception.
There was a problem hiding this comment.
I think we should throw exception.
Do we need to terminate directly here? Or do we add the warn log output, what do you think?
There was a problem hiding this comment.
An exception should be thrown because if there is no bug with the connector, it should never be null
There was a problem hiding this comment.
An exception should be thrown because if there is no bug with the connector, it should never be null
Ok, I see what you mean. I'll adjust. thx
Hisoka-X
approved these changes
Oct 25, 2024
|
waiting for ci passed |
hailin0
approved these changes
Oct 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support Doris multi read and close #5731
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.