Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Iceberg] Support table comment for catalog #7936

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[Improve][Iceberg] Support table comment for catalog #7936

merged 1 commit into from
Oct 29, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Oct 29, 2024

Purpose of this pull request

[Improve][Iceberg] Support table comment for catalog

Does this PR introduce any user-facing change?

No

How was this patch tested?

Add

Check list

Hisoka-X
Hisoka-X approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidzollo
davidzollo approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 72ab38f into apache:dev Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@davidzollo davidzollo davidzollo approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 iceberg reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hailin0 @davidzollo @Hisoka-X