[CI] Add pre-commit hook ClangFormat; format C files with style Google
#1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add this check to CI. If a commit has files that are not compliant, the CI should fail. |
jiayuasu
requested changes
Oct 13, 2024
…ogle` https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html#basedonstyle Standardizes the C code to one consistent format. https://github.com/pre-commit/mirrors-clang-format https://github.com/ssciwr/clang-format-wheel
jbampton
force-pushed
the
run-default-clang-format
branch
from
358451e
to
b821e4b
Compare
jbampton
changed the title
ClangFormat style GoogleGoogle
jiayuasu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://clang.llvm.org/docs/ClangFormat.html
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#basedonstyle
Standardizes the C code to one consistent format.
https://github.com/pre-commit/mirrors-clang-format
https://github.com/ssciwr/clang-format-wheel
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
What changes were proposed in this PR?
Ran ClangFormat.
How was this patch tested?
From the repo root on Linux I ran:
find python/ -name *.c -o -name *.h | xargs clang-format -i --style=GoogleDid this PR include necessary documentation updates?