[SEDONA-673] Fix issue when loading geoparquet file without bbox metadata. #1681
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontinuation
approved these changes
Nov 14, 2024
Kontinuation
changed the title
Kontinuation
changed the title
jiayuasu
requested changes
Nov 14, 2024
There was a problem hiding this comment.
- Can you replicate the test to all Spark versions?
- Can you add comments in the test case and explain this is using a geoparquet has no bbox in metadata?
jiayuasu
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
This PR is related to JIRA ticket SEDONA-673.
What changes were proposed in this PR?
When reading geoparquet which does not have bbox in metadata query like below fails with Index OutofBoundException
sparkSession.read .format("geoparquet") .load(overtureBBOX) .where("ST_Intersects(geometry, ST_PolygonFromEnvelope(0, 0, 1, 1))") .count()The issue was when evaluating predicate pushdowns
How to reproduce
Download data with the command
then try to load it with some predicate like contains or within.
How was this patch tested?
Unit test testing the given issue
Did this PR include necessary documentation updates?