Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-338] Fix RS_MakeEmptyRaster and make affine transformation parameters compliant with the GDAL/PostGIS convention #940

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

Kontinuation
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  1. Make RS_MakeEmptyRaster work correctly by constructing the GridCoverage2D object directly from the affine transformation. Please refer to SEDONA-338 for details.
  2. Grid coordinates are consistently treated as the upper-left corner of the grid cells. This behavior follows the GDAL/PostGIS convention.

How was this patch tested?

Add unit tests for geo-referencing related functions.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@Kontinuation Kontinuation marked this pull request as ready for review August 2, 2023 08:17
@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Aug 2, 2023
@jiayuasu jiayuasu merged commit 8d5c76d into apache:master Aug 2, 2023
39 checks passed
@Kontinuation Kontinuation deleted the geo-referencing-cell-corner branch August 23, 2023 15:12
Kontinuation added a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
…parameters compliant with the GDAL/PostGIS convention (apache#940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants