Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-349] Drop rarely used constructors and their tests in Java #954

Merged
merged 11 commits into from
Aug 10, 2023

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Aug 9, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Typed RDDs are PointRDD, LineStringRDD, PolygonRDD, and RectangleRDD.

  1. Drop the following typed RDD constructors and their test cases
    • Any constructors that have StorageLevel
    • Any constructors that have approximateCount and boundary envelope
  2. Automatically call analyze() functions in remaining typed RDD constructors
    • RDD spatial join needs approximateCount and boundary envelope. To maintain the same user experience, the analyze() function was added to avoid breaking behaviors.
  3. Drop the redundant typed RDD join tests.
  4. In Sedona R, the only constructors that are available all use StorageLevel. This PR has no impact to Sedona R.

Typed RDDs have soft deprecated since 1.4.0. We no longer provide instruction about how to use these typed RDDs.

How was this patch tested?

Passed the remaining unit tests

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu marked this pull request as draft August 10, 2023 07:59
@jiayuasu jiayuasu marked this pull request as ready for review August 10, 2023 08:39
@jiayuasu jiayuasu merged commit 9428bca into master Aug 10, 2023
39 checks passed
@jiayuasu jiayuasu deleted the fix-lonlat-order branch August 10, 2023 19:25
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant