Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unit tests and E2E from using host ports 1, 2181, 7181, 8181, 8899, 9000, 9181, 9872 and 9875 #2409

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Jul 27, 2024

Fixes #2408.

Changes proposed in this pull request:

  • Prevent unit tests and E2E from using host ports 1, 2181, 7181, 8181, 8899, 9000, 9181, 9872 and 9875. Starting from this PR, unit tests and E2E will automatically look for free ports to prevent third-party Docker Images such as portainer from using specific ports.
  • Since the host ports of 3181 and 18181 in the unit test are hard-coded into Spring Boot and various configuration files, they are retained.
  • Bump apache/curator to 5.7.0 .

@linghengqian linghengqian changed the title Prevent unit tests and E2E from using host ports 7181 and 9000 Prevent unit tests and E2E from using host ports 7181,9000 and 9181 Jul 27, 2024
@linghengqian linghengqian changed the title Prevent unit tests and E2E from using host ports 7181,9000 and 9181 Prevent unit tests and E2E from using host ports 7181, 9000 and 9181 Jul 27, 2024
@linghengqian linghengqian changed the title Prevent unit tests and E2E from using host ports 7181, 9000 and 9181 Prevent unit tests and E2E from using host ports 7181, 8181, 9000 and 9181 Jul 27, 2024
@linghengqian linghengqian changed the title Prevent unit tests and E2E from using host ports 7181, 8181, 9000 and 9181 Prevent unit tests and E2E from using host ports 3181, 7181, 8181, 9000, 9181 and 18181 Jul 27, 2024
@linghengqian linghengqian changed the title Prevent unit tests and E2E from using host ports 3181, 7181, 8181, 9000, 9181 and 18181 Prevent unit tests and E2E from using host ports 7181, 8181, 9000 and 9181 Jul 27, 2024
@linghengqian linghengqian changed the title Prevent unit tests and E2E from using host ports 7181, 8181, 9000 and 9181 Prevent unit tests and E2E from using host ports 7181, 8181, 9000, 9181 9872 and 9875 Jul 28, 2024
@linghengqian linghengqian changed the title Prevent unit tests and E2E from using host ports 7181, 8181, 9000, 9181 9872 and 9875 Prevent unit tests and E2E from using host ports 1, 2181, 7181, 8181, 8899, 9000, 9181, 9872 and 9875 Jul 28, 2024
@linghengqian linghengqian added the dependencies Pull requests that update a dependency file label Jul 28, 2024
… `8181`, `8899`, `9000`, `9181`, `9872` and `9875`
@taojintianxia taojintianxia merged commit 206a40e into apache:master Jul 28, 2024
12 checks passed
@linghengqian linghengqian added this to the 3.1.0 milestone Jul 28, 2024
@linghengqian linghengqian deleted the jdk22 branch July 28, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseSnapshotServiceE2ETest should not occupy port 9000 of the host
2 participants