Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize TracingProperties #2438

Merged
merged 3 commits into from
Sep 29, 2024
Merged

optimize TracingProperties #2438

merged 3 commits into from
Sep 29, 2024

Conversation

ooooooook
Copy link
Contributor

Changes proposed in this pull request:

  • optimize TracingProperties, add spring-configuration-metadata for nested DataSourceProperties

linghengqian
linghengqian requested changes Sep 29, 2024
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The PR did not pass the code formatting validation. You can execute first ./mvnw spotless:apply -Pcheck -T1C. Then execute ./mvnw checkstyle:check -Pcheck -T1C to manually adjust to repair the CI.

@linghengqian linghengqian added this to the 3.1.0 milestone Sep 29, 2024
linghengqian
linghengqian approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LGTM!
  • The instability of CI is caused externally and does not need to be discussed in the current PR.

@linghengqian linghengqian merged commit a7e56f9 into apache:master Sep 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghengqian linghengqian linghengqian approved these changes

Assignees
No one assigned
Labels
enhancement spring
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ooooooook @linghengqian