add destroyMethod for zookeeperRegistryCenter bean #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
- LGTM
- I still can't determine why the CI failed so quickly. In contrast, the CI for Adds documentation for connecting to Zookeeper Server with SASL enabled #2442 did not suffer from this. Proposal Integrate ge.apache.org in the project to prepare for possible performance testing #2413 is worth further consideration, but with https://ge.apache.org/ frequently going offline, I'm not sure if Gradle Inc. or ASF Infra has a bigger problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
destroyMethodfor thezookeeperRegistryCenterbean to ensure that the application removes the Zookeeper ephemeral node upon exit.