Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for Bootstrap use proxy default port from props #17707

Merged
merged 2 commits into from
May 16, 2022

Conversation

galaxylqx
Copy link
Contributor

Fixes #17003.

Changes proposed in this pull request:

  • add unit test for Bootstrap

@codecov-commenter
Copy link

Codecov Report

Merging #17707 (259184f) into master (e52989c) will decrease coverage by 0.00%.
The diff coverage is 73.07%.

@@             Coverage Diff              @@
##             master   #17707      +/-   ##
============================================
- Coverage     58.82%   58.81%   -0.01%     
  Complexity     2126     2126              
============================================
  Files          3599     3599              
  Lines         53570    53565       -5     
  Branches       9146     9146              
============================================
- Hits          31510    31505       -5     
  Misses        19386    19386              
  Partials       2674     2674              
Impacted Files Coverage Δ
...infra/metadata/database/loader/DatabaseLoader.java 0.00% <ø> (ø)
...ere/infra/metadata/schema/loader/SchemaLoader.java 0.00% <ø> (ø)
...de/manager/memory/MemoryContextManagerBuilder.java 0.00% <0.00%> (ø)
.../manager/cluster/ClusterContextManagerBuilder.java 65.59% <66.66%> (ø)
...he/shardingsphere/mode/manager/ContextManager.java 62.02% <83.33%> (-0.44%) ⬇️
...gsphere/mode/metadata/MetaDataContextsBuilder.java 96.96% <100.00%> (ø)
...er/standalone/StandaloneContextManagerBuilder.java 87.50% <100.00%> (ø)
...d/text/distsql/ral/common/hint/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️
.../sql/prepare/ExecutionPrepareDecoratorFactory.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125e5a1...259184f. Read the comment docs.

@terrymanu terrymanu merged commit 120d4f5 into apache:master May 16, 2022
@terrymanu terrymanu added this to the 5.1.2 milestone May 16, 2022
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this pull request May 17, 2022
* master: (90 commits)
  Remove usage of com.google.common.collect.Collections2 (apache#17721)
  Refactor execute RAL  statement reload metaData (apache#17720)
  Use caffeine instead of guava cache (apache#17712)
  Minor changes for test cases and code format (apache#17718)
  Add test case for RuleBasedSchemaMetaDataBuilderFactory . (apache#17709)
  Update Mockito and ByteBuddy to help with GraalVM integration (apache#17665)
  fix CI error (apache#17713)
  Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit)  apache#16091 (apache#17714)
  Remove useless DatabaseMetaDataContextsBuilder (apache#17717)
  private MetaDataContextsBuilder.addDatabase and addSystemDatabases (apache#17716)
  Add unit test for ModShardingAlgorithm  (apache#17710)
  Refactor distribute database lock (apache#17711)
  Add unit test for Bootstrap use proxy default port from props (apache#17707)
  Scaling IT optimization (apache#17702)
  Add test cases for SQLRewriteContextDecoratorFactory and ExecutionPrepareDecoratorFactory . (apache#17701)
  Use ConfigurationProperties in ContextManager (apache#17706)
  Use ConfigurationProperties in MetaDataContextsBuilder (apache#17705)
  Refactor create schema statement parse logic (apache#17703)
  Revise apache#17695 (apache#17700)
  add test for DataNodeBuilderFactory (apache#17695)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support default proxy port configurable
3 participants