Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DDL genereate method at migration prepare #20245

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Conversation

azexcy
Copy link
Contributor

@azexcy azexcy commented Aug 17, 2022

Revise #20207

Changes proposed in this pull request:

  • Improve DDL generate.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (ae4afbd) to head (2a17a36).
Report is 8645 commits behind head on master.

Files with missing lines Patch % Lines
.../core/metadata/generator/PipelineDDLGenerator.java 0.00% 17 Missing ⚠️
...eline/scenario/migration/MigrationJobPreparer.java 0.00% 15 Missing ⚠️
...prepare/datasource/AbstractDataSourcePreparer.java 0.00% 12 Missing ⚠️
...epare/datasource/PrepareTargetTablesParameter.java 0.00% 9 Missing ⚠️
...ql/prepare/datasource/MySQLDataSourcePreparer.java 0.00% 2 Missing ⚠️
...repare/datasource/OpenGaussDataSourcePreparer.java 0.00% 1 Missing ⚠️
...epare/datasource/PostgreSQLDataSourcePreparer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20245      +/-   ##
============================================
+ Coverage     60.86%   60.87%   +0.01%     
- Complexity     2421     2422       +1     
============================================
  Files          3873     3876       +3     
  Lines         54673    54690      +17     
  Branches       9306     9310       +4     
============================================
+ Hits          33275    33295      +20     
+ Misses        18545    18542       -3     
  Partials       2853     2853              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandynz sandynz merged commit 3b15d53 into apache:master Aug 18, 2022
@azexcy azexcy deleted the dev branch August 18, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants