-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update library to serve building GraalVM Native Image #21571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2022
linghengqian
force-pushed
the
graalvm-metadata
branch
from
October 14, 2022 15:09
3cc6f1c
to
33ed81c
Compare
Codecov Report
@@ Coverage Diff @@
## master #21571 +/- ##
============================================
+ Coverage 61.05% 61.06% +0.01%
- Complexity 2509 2511 +2
============================================
Files 4111 4111
Lines 57295 57270 -25
Branches 7588 7587 -1
============================================
- Hits 34979 34972 -7
+ Misses 19381 19363 -18
Partials 2935 2935
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
linghengqian
force-pushed
the
graalvm-metadata
branch
6 times, most recently
from
October 15, 2022 05:31
68cc6fe
to
b456187
Compare
linghengqian
force-pushed
the
graalvm-metadata
branch
from
October 15, 2022 05:45
b456187
to
54cb810
Compare
linghengqian
force-pushed
the
graalvm-metadata
branch
from
October 15, 2022 06:48
d97672f
to
85f31cd
Compare
terrymanu
reviewed
Oct 15, 2022
|
|
Great, I will review soon |
terrymanu
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #21347.
Changes proposed in this pull request:
junit-vintage-engine
to support unit testing inside GraalVM Native Image. Reference Support JUnit 4 via the VintageTestEngine graalvm/native-build-tools#53 .4.1.84
to get the new automatically generate native-imageconditional
metadata forChannelHandler
implementations. See Automatically generate native-image conditional metadata for ChannelHandler implementations. netty/netty#12794 .logback
to match graalvm reachability metadata at https://github.com/oracle/graalvm-reachability-metadata/tree/master/metadata/ch.qos.logback/logback-classic/1.2.11 .maven-surefire-plugin
to milestone version to automatically handle use oforg.junit.platform:junit-platform-launcher
. Reference https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#testing-support-version-compatibility .mockito
andbyte-buddy
to be in sync with the latestJunit Platform
requirements as much as possible.hikaricp
, it has some breaking changes from3.4.2
to4.0.3
. I'll continue to see how it should be handled at Make ShardingSphere Proxy in GraalVM Native Image form available #21347 .Before committing this PR, I'm sure that I have checked the following options:
mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e
.