Refactor class-based-sharding-algorithm-example with ShardingSphereDriver #22525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22525 +/- ##
=========================================
Coverage 50.98% 50.98%
Complexity 2514 2514
=========================================
Files 4185 4185
Lines 58237 58237
Branches 9902 9902
=========================================
Hits 29694 29694
Misses 26013 26013
Partials 2530 2530 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RaigorJiang
reviewed
Nov 30, 2022
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-test</artifactId> |
There was a problem hiding this comment.
Why do we need to dependen on spring-boot-starter-test?
RaigorJiang
reviewed
Nov 30, 2022
| props: | ||
| sharding-count: 4 | ||
|
|
||
|
|
RaigorJiang
reviewed
Nov 30, 2022
| props: | ||
| sharding-count: 4 | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #22469.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.