Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor class-based-sharding-algorithm-example with ShardingSphereDriver #22534

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

Pace2Car
Copy link
Contributor

For #22469 .

Changes proposed in this pull request:

  • Refactor class-based-sharding-algorithm-example with ShardingSphereDriver
  • Remove Spring configuration example

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@codecov-commenter
Copy link

Codecov Report

Merging #22534 (d8b0bfa) into master (7e6d00d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #22534   +/-   ##
=========================================
  Coverage     50.93%   50.94%           
  Complexity     2515     2515           
=========================================
  Files          4189     4189           
  Lines         58290    58290           
  Branches       9912     9912           
=========================================
+ Hits          29692    29695    +3     
+ Misses        26067    26064    -3     
  Partials       2531     2531           
Impacted Files Coverage Δ
...handler/distsql/ral/hint/enums/HintSourceType.java 42.85% <0.00%> (+42.85%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RaigorJiang RaigorJiang merged commit 794a8de into apache:master Nov 30, 2022
@Pace2Car Pace2Car deleted the refactor-example-class-based branch November 30, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants